[flang-commits] [flang] [flang] de-duplicate AbstractResult pass (PR #88867)

via flang-commits flang-commits at lists.llvm.org
Wed Apr 17 02:11:55 PDT 2024


https://github.com/jeanPerier commented:

Thanks Tom for cleaning this up! Making this more modular makes sense to me.
Question inlined because I do not get why both `addNested<Op>` and `canBeScheduled` are needed here (but I am not an expert in pass pipeline at all).

Regarding the ReturnOp issue you saw, is it related to the weird way the ReturnOp op pattern is inserted (only inserted when the top level op is a function)? Maybe the pattern could just always be registered (just unused if there is not ReturnOp).

https://github.com/llvm/llvm-project/pull/88867


More information about the flang-commits mailing list