[flang-commits] [flang] [flang][OpenMP] Re-enable tests when building OpenMP as a runtime (PR #89046)

[Michael Klemm via flang-commits]

mjklemm wrote:

I was playing with the option to extend the `extra_args` field of `ToolSubst`.  But then, if the OpenMP runtime is enabled, it would inject `-J` for all tests not only the OpenMP tests.  I kind of felt that this was a bit too much.  That's why I went with the option of having `%openmp_module_flag` and putting the burden on the OpenMP tests only.  I was hoping that the usual test of creating a new test is by "borrowing" from an existing test and thus automatically getting `%openmp_module_flag` into the new test.

Other options that I see (happy to get more)
- Have an extension to Flang to pick up `-J` and `-I` from the environment (similar to `LIBRARY_PATH` or `INCLUDE_PATH` with C compilers)
- Change the build system to copy/link/move omp_lib.mod from where it lives for runtime builds to where it lives when doing a project build

https://github.com/llvm/llvm-project/pull/89046