[flang-commits] [flang] [mlir] [mlir][math] Replace roundeven call by nearbyint call when target does not have C23 features (PR #88687)

Corentin Ferry via flang-commits flang-commits at lists.llvm.org
Mon Apr 15 07:46:22 PDT 2024


================
@@ -185,8 +186,15 @@ void mlir::populateMathToLibmConversionPatterns(RewritePatternSet &patterns) {
   populatePatternsForOp<math::Log10Op>(patterns, ctx, "log10f", "log10");
   populatePatternsForOp<math::Log1pOp>(patterns, ctx, "log1pf", "log1p");
   populatePatternsForOp<math::PowFOp>(patterns, ctx, "powf", "pow");
-  populatePatternsForOp<math::RoundEvenOp>(patterns, ctx, "roundevenf",
-                                           "roundeven");
+  if (options.allowC23Features)
----------------
cferry-AMD wrote:

Right, as also suggested by the `flang` issue raised earlier. So maybe an `allow-roundeven` flag? I'm not keen on adding a flag this specific, but if nothing else in MathToLibm appears to need a flag, that could just be it.

https://github.com/llvm/llvm-project/pull/88687


More information about the flang-commits mailing list