[flang-commits] [flang] [OpenMP][Flang] Add "IsolatedFromAbove" and "OutlineableOpenMPOpInterface" trait to omp.target (PR #67164)

[via flang-commits]

agozillon wrote:

> > Add IsolatedFromAbove and OutlineableOpenMPOpInterface traits to target op in MLIR.
> 
> The `OutlineableOpenMPOpInterface` looks like a separate change.
> 
> > Move implicit operand capturing to the PFT lowering stage.
> 
> Could you expand on what is being done for the `implicit` operands? Are they added to the map operands? Or are they just entry block arguments?
> 
> Could you also comment on (and add to the summary) why this is advantageous to the outlining approach?

I think there should be both map and block arguments, former to make lowering easier and carry map information for the captures, whilst making the mapping more explicit to readers of the IR and the latter to fulfil the IsolatedFromAbove interface, I think this patch does that currently. Perhaps sometime in the future the BlockArgs and Map clauses can be aligned so we only have one, not too sure how you'd go about doing that though, perhaps make an extended BlockArgs operator for Map or a map clause interface for BlockArgs. 

https://github.com/llvm/llvm-project/pull/67164