[flang-commits] [flang] [Flang][OpenMP] Move array bounds tests to HLFIR lowering (PR #67328)

[via flang-commits]

agozillon wrote:

> This is a copy of the test in flang/test/Lower/OpenMP/FIR/array-bounds.f90 The device test is crashing in the Early Outlining pass. Since this pass is going to be removed, will wait before the device part is updated.

This is the unfortunate part about that pass I think, at least from my experience so far, any new operations that are required for later lowering or for keeping consistency in the kernel related IR/map operations needs to be cloned over, or you can get verification errors at the end of the pass/lose information needed for later lowering. Doesn't really mesh well with the idea of integrating new MLIR dialects or operations easily sadly. Although, perhaps there's a way around this problem I did not consider.

I did not get a chance to test the device flow with HLFIR yet sadly, if the pass ends up staying around I can look into the device failure and check any other HLFIR related issues we currently have with the pass and update it and just generally maintain it as neccessary. But otherwise for now moving it and switching it to host only LGTM. 

https://github.com/llvm/llvm-project/pull/67328