[flang-commits] [flang] [flang] Add comdats to functions with linkonce linkage (PR #66516)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Fri Sep 15 09:57:28 PDT 2023


================
@@ -3861,6 +3862,14 @@ class FIRToLLVMLowering
                                                std::move(pattern)))) {
       signalPassFailure();
     }
+
+    // Run pass to add comdats to functions that have weak linkage on relevant platforms
+    if (fir::getTargetTriple(mod).supportsCOMDAT()) {
----------------
tblah wrote:

Would it be easier to move this if statement to `flang/include/flang/Tools/CLOptions.inc` and re-use the existing pass manager? To me it feels a bit weird to create a new pass manager inside of a pass. 

https://github.com/llvm/llvm-project/pull/66516


More information about the flang-commits mailing list