[flang-commits] [flang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

Nathan Sidwell via flang-commits flang-commits at lists.llvm.org
Wed Sep 13 16:06:06 PDT 2023


================
@@ -24790,8 +24790,8 @@ static SDValue LowerVACOPY(SDValue Op, const X86Subtarget &Subtarget,
   return DAG.getMemcpy(
       Chain, DL, DstPtr, SrcPtr,
       DAG.getIntPtrConstant(Subtarget.isTarget64BitLP64() ? 24 : 16, DL),
-      Align(Subtarget.isTarget64BitLP64() ? 8 : 4), /*isVolatile*/ false, false,
-      false, MachinePointerInfo(DstSV), MachinePointerInfo(SrcSV));
+      Align(Subtarget.isTarget64BitLP64() ? 8 : 4), /*Vol=*/{false, false},
----------------
urnathan wrote:

good idea, something like `MemTransferVolatility().setDst(true/false).setSrc(true/false)` ? Do you have preference for names?

https://github.com/llvm/llvm-project/pull/65748


More information about the flang-commits mailing list