[flang-commits] [flang] [flang][openacc] Fixed bounds for full array sections. (PR #70859)

via flang-commits flang-commits at lists.llvm.org
Tue Oct 31 16:16:51 PDT 2023


agozillon wrote:

> As I understand, this should affect OpenMP as well, but none of OpenMP LIT tests failed.

It does, but I think OpenACC tests the bounds generation a little more strictly than the tests I've added so far for the bounds, which are primarily just some lit tests to make sure fortran generated the bounds as expected in certain cases and then using those bounds to test further lowering to LLVM-IR. 

However, if something was going to fail it would likely fail an openmp/libomptarget/offloading test e.g. https://github.com/llvm/llvm-project/blob/main/openmp/libomptarget/test/offloading/fortran/basic-target-region-3D-array-section.f90 but they're not really testable without an AMD GPU and I'm fairly certain none of the upstream buildbots run these tests at the moment so it won't fail a buildbot (nothing that compiles Flang and runs OpenMP tests with AMD GPU offload). 

I could test this PR tomorrow and if it breaks anything create another PR that can be approved and merged at the same time by you or incorporated into this patch. Or if we're in a bit of a hurry to land this, I can test they all work reasonably after this patch lands and create a fix if they do not. Whatever works best.

https://github.com/llvm/llvm-project/pull/70859


More information about the flang-commits mailing list