[flang-commits] [flang] [flang][codegen] Update FIR codegen to use mlir.llvm opaque pointers (PR #69692)

Markus Böck via flang-commits flang-commits at lists.llvm.org
Fri Oct 20 03:05:13 PDT 2023


https://github.com/zero9178 commented:

Thank you so much for doing this and the incredible turnaround time! 
I don't have any complaints regardings LLVM Dialect/opaque pointer usage and I am happy to see that the PR ends up being more red than green :slightly_smiling_face:
 
I am not really qualified to comment on Flang specifics things so I'll leave this to other reviewers.
I did leave two comments about things that confused me as a flang outsider that I am curious about whether it is correct or whether I am simply missing some required context. 

https://github.com/llvm/llvm-project/pull/69692


More information about the flang-commits mailing list