[flang-commits] [flang] [Driver] Link Flang runtime on Solaris (PR #65644)

Rainer Orth via flang-commits flang-commits at lists.llvm.org
Mon Oct 16 03:47:01 PDT 2023


rorth wrote:

> I feel that we are bike-shedding here a bit. Please prioritise correctness - using `GNU` as a label for Solaris would not be correct. The following would be:
> 
>     * duplicating tests with a different label (e.g. `SOLARIS`) would be correct,
> 
>     * renaming the current label from `GNU` to e.g. `UNIX` would be correct.
> 
> 
> Unless I am missing something?

I'd go for renaming the label to `UNIX` then: it avoids unnecessary duplication and better describes what those cases are about.

https://github.com/llvm/llvm-project/pull/65644


More information about the flang-commits mailing list