[flang-commits] [flang] [flang] Put ISO_Fortran_binding.h where it can be easily used (PR #68756)

Slava Zakharin via flang-commits flang-commits at lists.llvm.org
Fri Oct 13 10:20:58 PDT 2023


================
@@ -64,6 +64,7 @@ set(FLANG_TEST_DEPENDS
   FortranRuntime
   Fortran_main
   FortranDecimal
+  clang
----------------
vzakhari wrote:

> For the dependency with clang, Do we really want to check with the clang just built or is it sufficient to check with the clang installed on the system? Also, is it OK to check with the system compiler?

Yes, we need to check with the `clang` that has just been built.   The test is checking that `clang` is able to find the header file, so `clang` used for the test is the one which has the header file in its "installation" structure.

If we change the LIT test from `clang` compilation +`flang` compilation + execution into just `clang` compilation, then we can move this functionality into `clang/lib/Headers` completely.

We can have an end-to-end test with `clang`/`flang`/executable in llvm-test-suite as you suggested.

I think adding `clang` dependency is too much overhead.

https://github.com/llvm/llvm-project/pull/68756


More information about the flang-commits mailing list