[flang-commits] [flang] [flang]Check for dominance in loop versioning (PR #68797)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Wed Oct 11 05:20:34 PDT 2023


================
@@ -309,12 +312,11 @@ void LoopVersioningPass::runOnOperation() {
       for (auto a : argsOfInterest) {
         if (a.arg == normaliseVal(operand)) {
           // Use the reboxed value, not the block arg when re-creating the loop.
-          // TODO: should we check that the operand dominates the loop?
-          // If this might be a case, we should record such operands in
-          // argsInLoop.cannotTransform, so that they disable the transformation
-          // for the parent loops as well.
----------------
kiranchandramohan wrote:

Copy this comment below describing the change, instead of removing?

https://github.com/llvm/llvm-project/pull/68797


More information about the flang-commits mailing list