[flang-commits] [flang] [flang][FIR] add FirAliasAnalysisOpInterface (PR #68317)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Fri Oct 6 02:40:48 PDT 2023


tblah wrote:

Thanks for taking a look. My interface is just a stripped down version of the one in mlir::LLVMIR: https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td#L124. I named it to mirror the name used there. Presumably once full restrict is merged, it will be added to that interface in LLVMIR and we can copy it here.

But if we would like to implement alias analysis via interfaces, maybe we would be better renaming this something like `AliasTagOpInterface` so it is clear that this one is for propagating alias information rather than performing the analysis. I would prefer not to put TBAA in the name so that this interface can be evolved over time to represent alias information in other ways (e.g. full restrict).

@Renaud-K I think we can still move in that direction. As I understand it, the implementation of `fir::AliasAnalysis` should be orthogonal to what I am doing here. Will the interface stay the same? I would like to keep `fir::AliasAnalysis::getSource`.

https://github.com/llvm/llvm-project/pull/68317


More information about the flang-commits mailing list