[flang-commits] [flang] Update MLIR conversion to LLVMFunc to account better for properties (PR #67406)

[Oleksandr Alex Zinenko via flang-commits]

ftynse wrote:

> @ftynse I added the `sym_visibility` to LLVMFuncOp, can you double check that it makes sense here?

I think we discussed making visibility a part of symbol interface and having it depend on the linkage attribute for LLVMFuncOp. That would be my preferred solution. Howevre, @jpienaar had an argument about having private linkage yet public visibility (or vice versa) functions somehow, but I don't remember what it was. @gysit may also know better given that they have cases of converting from LLVM IR to the LLVM dialect and inlining at that level.

https://github.com/llvm/llvm-project/pull/67406