[flang-commits] [flang] [flang] Make adapt.valuebyref attribute work again (PR #73658)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Tue Nov 28 07:48:06 PST 2023


================
@@ -243,7 +243,8 @@ hlfir::AssociateOp genAssociateExpr(mlir::Location loc,
                                     fir::FirOpBuilder &builder,
                                     hlfir::Entity value,
                                     mlir::Type variableType,
-                                    llvm::StringRef name);
+                                    llvm::StringRef name,
+                                    std::optional<mlir::NamedAttribute> attr);
----------------
tblah wrote:

nit to avoid code churn
```suggestion
                                    std::optional<mlir::NamedAttribute> attr = std::nullopt);
```

https://github.com/llvm/llvm-project/pull/73658


More information about the flang-commits mailing list