[flang-commits] [flang] [flang][OpenMP] Fix construct privatization in default clause (PR #72510)

[Leandro Lupori via flang-commits]

================
@@ -426,14 +425,10 @@ void DataSharingProcessor::collectSymbols(
                              /*collectSymbols=*/true,
                              /*collectHostAssociatedSymbols=*/true);
   for (Fortran::lower::pft::Evaluation &e : eval.getNestedEvaluations()) {
-    if (e.hasNestedEvaluations())
+    if (e.hasNestedEvaluations() && !e.isConstruct())
       converter.collectSymbolSet(e, symbolsInNestedRegions, flag,
                                  /*collectSymbols=*/true,
                                  /*collectHostAssociatedSymbols=*/false);
-    else
-      converter.collectSymbolSet(e, symbolsInParentRegions, flag,
-                                 /*collectSymbols=*/false,
-                                 /*collectHostAssociatedSymbols=*/true);
----------------
luporl wrote:

With this change and that in `collectSymbolSet()`, it seems that host associated symbols are never collected anymore, isn't it? If this is the case, can't we remove the `collectHostAssociatedSymbols` and `collectSymbols` flags from `collectSymbolSet()`?

https://github.com/llvm/llvm-project/pull/72510