[flang-commits] [flang] Fix for building llvm-flang with gcc 7.5.0 (minimum LLVM required gcc version (PR #73265)

Mehdi Amini via flang-commits flang-commits at lists.llvm.org
Thu Nov 23 17:15:04 PST 2023


================
@@ -63,9 +63,8 @@ constexpr std::array<std::string_view, ITEMS> EnumNames(const char *p) {
   [[maybe_unused]] static constexpr std::size_t NAME##_enumSize{ \
       ::Fortran::common::CountEnumNames(#__VA_ARGS__)}; \
   [[maybe_unused]] static inline std::string_view EnumToString(NAME e) { \
-    static const constexpr char vaArgs[]{#__VA_ARGS__}; \
     static const constexpr auto names{ \
-        ::Fortran::common::EnumNames<NAME##_enumSize>(vaArgs)}; \
----------------
joker-eph wrote:

Was there any reason this was written this way in the first place? Did you find the original review that introduced this?
(just want to make sure this wasn't initially split to work around another issue).

https://github.com/llvm/llvm-project/pull/73265


More information about the flang-commits mailing list