[flang-commits] [flang] [Flang] Add new Integration tests directory to Flang (PR #73141)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Thu Nov 23 03:38:20 PST 2023


https://github.com/kiranchandramohan approved this pull request.

LGTM subject to the following. Please add a pointer to this patch in the RFC.

Since you have not added a CMake flag to enable the tests in this directory, it is important to convey that tests here should be used only under particular circumstances.
Please add a Readme file in the flang/test/Integration directory saying that "This directory can be used to add Integration tests involving multiple stages of the compiler (for eg. from Fortran to LLVM IR). It should not contain executable tests. We should only add tests here sparingly and only if there is no other way to test. Repeat this message in each test that is added to this directory and sub-directories."

https://github.com/llvm/llvm-project/pull/73141


More information about the flang-commits mailing list