[flang-commits] [mlir] [flang] [mlir] Expose type and attribute names in the MLIRContext and abstract type/attr classes (PR #72189)

Fehr Mathieu via flang-commits flang-commits at lists.llvm.org
Sun Nov 19 20:35:47 PST 2023


math-fehr wrote:

I moved `getTypeName` and `getAttrName` to just a `name` field, so that it will be the same for both attributes and types, and also would not clash with any `name` parameter that could be define in ODS.
Do you think that make sense, or do you think that this is too much different than operations (that have a `getName` static method). Or do you think this should also be changed in operations?

Also, I added the change in `MLIRContext` so that we store a `DensMap` of `StringAttr` rather than a `StringMap`.

Currently, I have a `Address boundary error` when `build/NATIVE/bin/mlir-linalg-ods-yaml-gen` is being used in the build. I'm trying to figure out if it's because of the `::name` change, or the `StringAttr`.

https://github.com/llvm/llvm-project/pull/72189


More information about the flang-commits mailing list