[flang-commits] [libunwind] [compiler-rt] [libcxx] [mlir] [lldb] [lld] [flang] [clang-tools-extra] [libc] [libcxxabi] [llvm] [clang] PR#72453 : Exceeding maximum file name length (PR #72654)

[Todd A. Anderson via flang-commits]

================
@@ -17,6 +17,8 @@
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/GraphWriter.h"
 
+static std::vector<std::string> nameObj;
----------------
DrTodd13 wrote:

I don't know if there is some LLVM code approach that would dictate what to do here.  We can have some kind of a data structure to remember names to try to avoid duplicates or we can accept that there may be duplicates but just make them probabilistically rare.  I guess I am leaning toward the latter where you do something like take up to a certain number of characters of the filename as they are but then you take the rest of the characters of the filename and hash them and add the hash to the filename.  This latter approach works even if you are going in and out of llvm whereas having a data structure to remember names would only work in the context of single execution of LLVM.  Again, that is just my opinion and I'm not sure what people with approval authority here will say.

https://github.com/llvm/llvm-project/pull/72654