[flang-commits] [clang] [clang-tools-extra] [llvm] [compiler-rt] [flang] [clang] Add support for new loop attribute [[clang::code_align()]] (PR #70762)

Erich Keane via flang-commits flang-commits at lists.llvm.org
Thu Nov 16 11:28:45 PST 2023


================
@@ -359,16 +359,34 @@ static Attr *handleCodeAlignAttr(Sema &S, Stmt *St, const ParsedAttr &A) {
 static void
 CheckForDuplicateCodeAlignAttrs(Sema &S,
                                 const SmallVectorImpl<const Attr *> &Attrs) {
-  const Attr *A = nullptr;
-  for (const auto *I : Attrs) {
-    if (isa<CodeAlignAttr>(I)) {
-      if (A) {
-        S.Diag(I->getLocation(), diag::err_loop_attr_duplication) << A;
-        S.Diag(A->getLocation(), diag::note_previous_attribute);
-      }
-      A = I;
+    const auto *FirstItr =
----------------
erichkeane wrote:

I apprently commented in teh wrong place, but see my comment/suggestion here: https://github.com/llvm/llvm-project/commit/09b00c761f177c3c6ad2285fa5b7642f9c7d28cc

https://github.com/llvm/llvm-project/pull/70762


More information about the flang-commits mailing list