[flang-commits] [flang] [flang] Change `uniqueCGIdent` separator from `.` to `X` (PR #71338)

via flang-commits flang-commits at lists.llvm.org
Wed Nov 8 10:23:19 PST 2023


https://github.com/jeanPerier approved this pull request.

Thanks for working on the issue and for the update. I think you may have forgotten to push the updated mangling doc to mention X is now used as a separator in internal names. Otherwise looks great.

Also, you may want to locally rebase and test your PR with check-flang before merging to ensure that no new tests with QQcl. made it in the main branch during the review.

https://github.com/llvm/llvm-project/pull/71338


More information about the flang-commits mailing list