[flang-commits] [PATCH] D151106: [flang][NFC] Move Array constructor inlined temp management into a utility

[Jean Perier via Phabricator via flang-commits]

jeanPerier marked an inline comment as done.
jeanPerier added inline comments.


================
Comment at: flang/lib/Optimizer/Builder/TemporaryStorage.cpp:99-102
+  // TODO: "copy" would probably be better than assign to ensure there are no
+  // side effects (user assignments, temp, lhs finalization)?
+  // This only makes a difference for derived types, and for now derived types
+  // will use the runtime strategy to avoid any bad behaviors.
----------------
tblah wrote:
> nit: please could you add a TODO checking that no derived types get here, just in case the strategy is changed later and this file is forgotten about.
Good point, I turned the assert into a TODO here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151106/new/

https://reviews.llvm.org/D151106