[flang-commits] [PATCH] D149116: [Fortran/gfortran] Enable "compile" tests from the gfortran torture test suite

[Tarun Prabhu via Phabricator via flang-commits]

tarunprabhu marked 2 inline comments as done.
tarunprabhu added a comment.

Thanks for the review, @luporl

In D149116#4343386 <https://reviews.llvm.org/D149116#4343386>, @luporl wrote:

> But I am not familiar with llvm-test-suite. Do you have an idea of
> how much effort would be required?

Yes, I agree that modifying the test suite would be a better idea in the long run. However, I, too, am not very familiar with the llvm-test-suite so I am not sure just how much work it would be. I wanted to just get something working for now so we have a larger suite of tests that the community can use.

I could look into the modifying the test-suite itself, but I would like to prioritize getting most of the gfortran test-suite working first.

> It would also be nice to update Fortran/gfortran/README.md, unless you are planning to do it later, when more compile tests are supported.

Done.



================
Comment at: Fortran/gfortran/torture/compile/CMakeLists.txt:159-162
+list(APPEND UnsupportedTests "")
+list(APPEND UnimplementedTests "")
+list(APPEND SkippedTests "")
+list(APPEND FailingTests "${Failing}")
----------------
luporl wrote:
> Is it expected that UnsupportedTests/UnimplementedTests/SkippedTests will receive entries when more compile tests are enabled?
Yes, it is possible if gfortran adds more tests to this list and if they exercise features that we don't support, for instance. The idea is for these tests to be periodically synced with gfortran so we can take advantage of any more tests that they add.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149116/new/

https://reviews.llvm.org/D149116