[flang-commits] [PATCH] D149449: [flang][hlfir] Add hlfir.elemental_addr for vector subscripted assignment

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

Thanks for the reviews!



================
Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.td:903
+  let summary = "Yield the address of a vector subscripted variable inside an hlfir.region_assign";
+  let description = [{
+    Special terminator node for the left-hand side region of an hlfir.region_assign
----------------
tblah wrote:
> Please could you mention the cleanup region in the description
Good point, done.


================
Comment at: flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp:1035
         "right-hand side region must be terminated by an hlfir.yield");
   // TODO: allow hlfir.elemental_addr.
+  if (!mlir::isa_and_nonnull<hlfir::YieldOp, hlfir::ElementalAddrOp>(
----------------
vzakhari wrote:
> TODO is probably redundant now.
Indeed, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149449/new/

https://reviews.llvm.org/D149449