[flang-commits] [PATCH] D149626: [flang] Add `co_reduce` to the list of intrinsics and update test

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added inline comments.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:2807
+  if (name == "reduce") {
+    std::transform(name.begin(), name.end(), name.begin(), ::toupper);
+  }
----------------
Here, I have transformed the string with the name of the intrinsic, if it is `reduce`, to match the form of the error messages that occurred before this patch for the `reduce` intrinsic. However, I don't have to do this. I am happy to do whatever is preferred. At the moment, for other error messages for other intrinsics, some of them have the intrinsic name and the argument names in all caps, and some have them all in lower case, so I wasn't sure which pattern I should try to match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149626/new/

https://reviews.llvm.org/D149626