[flang-commits] [PATCH] D153910: [flang] Honor #line and related preprocessing directives

Wed Jun 28 08:07:50 PDT 2023

klausler added a comment.

In D153910#4455483 <https://reviews.llvm.org/D153910#4455483>, @domada wrote:

> LGTM.
> Thank you for your patch. 
> I tested it, and it solves all issues connected with -save-temps flag, which were mentioned on LLVM discourse <https://discourse.llvm.org/t/rfc-flang-improve-debug-information-user-error-messages-and-fix-openmp-function-mismatch-for-save-temps-flag/71417/16>.

This kind of testing is the most useful kind of code review; thanks for confirming that your problem will be solved.  I've updated the patch and it should now clear the pre-merge testing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153910/new/

https://reviews.llvm.org/D153910