[flang-commits] [PATCH] D153858: [flang] do not merge block after lowering

[vdonaldson via Phabricator via flang-commits]

vdonaldson added a comment.

Does block coalescing still happen later in the compilation pipeline? That's a nice optimization that we don't want to completely lose.



================
Comment at: flang/lib/Lower/Bridge.cpp:4181
     // Eliminate dead code as a prerequisite to calling other IR passes.
     // FIXME: This simplification should happen in a normal pass, not here.
     mlir::IRRewriter rewriter(*builder);
----------------
Is this FIXME comment (still) valid?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153858/new/

https://reviews.llvm.org/D153858