[flang-commits] [PATCH] D153759: [flang][hlfir] Add codegen for vector subscripted LHS

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/test/HLFIR/order_assignments/vector-subscripts-codegen.fir:119
+// CHECK:             }
+// CHECK:             hlfir.destroy %[[VAL_29:.*]] : !hlfir.expr<10xf32>
+// CHECK:           }
----------------
tblah wrote:
> Should this be destroying VAL_16 (the result of the elemental)?
Thanks for the review! Yes, this is indeed destroying VAL_16, for some reason the generate-test-checks.py utility is not making the link and is creating a new capture here. I updated it manually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153759/new/

https://reviews.llvm.org/D153759