[flang-commits] [PATCH] D153516: [flang][hlfir] user defined assignment codegen

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIROrderedAssignments.cpp:382
+    if (fir::isa_trivial(mold.getType()))
+      // fir.ref<T> to T.
+      return hlfir::Entity{builder.create<fir::LoadOp>(loc, input)};
----------------
tblah wrote:
> How do we know that T doesn't need conversion?
We do not, thanks for catching this, I added convert here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153516/new/

https://reviews.llvm.org/D153516