[flang-commits] [PATCH] D152307: [Fortran/gfortran] Fix build-time and test-time race conditions

Tarun Prabhu via Phabricator via flang-commits flang-commits at lists.llvm.org
Tue Jun 6 13:38:27 PDT 2023


tarunprabhu created this revision.
tarunprabhu added reviewers: kiranchandramohan, sscalpone, lenary, luporl, PeteSteinfeld, klausler, DavidTruby, rovka.
tarunprabhu added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
tarunprabhu requested review of this revision.

There are currently several race conditions between tests in the test-suite which prevents them from being build and/or tested in parallel. Several tests produce the same module file at build-time while others create/read/write the same file at runtime. This patch does the following:

1. A separate module directory is created for each test. Any .mod files produced by the test will be written into that module. In the case of multi-file tests, modules produced by any file will be written to that same directory.

2. A separate working directory is created for each "execute" test and the test suite is instructed to run the test in that directory. The tests, as they are currently written, create/write/read files from $PWD. This ensures that files created by different tests do not conflict.

3. The tests that were previously disabled because of these race conditions have been enabled.


Repository:
  rT test-suite

https://reviews.llvm.org/D152307

Files:
  Fortran/gfortran/CMakeLists.txt
  Fortran/gfortran/regression/CMakeLists.txt
  Fortran/gfortran/torture/execute/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152307.529018.patch
Type: text/x-patch
Size: 5396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230606/90a6f134/attachment-0001.bin>


More information about the flang-commits mailing list