[flang-commits] [PATCH] D155962: [flang] Compare component types In AreSameComponent()

Fri Jul 21 14:20:05 PDT 2023

klausler added a comment.

Fixed!  Thanks for the clear explanation.

From: Paul Robinson via Phabricator <reviews at reviews.llvm.org>
Date: Friday, July 21, 2023 at 14:14
To: Peter Klausler <pklausler at nvidia.com>, clementval at gmail.com <clementval at gmail.com>, Steve Scalpone <sscalpone at nvidia.com>
Cc: jdoerfert at anl.gov <jdoerfert at anl.gov>, flang-commits at lists.llvm.org <flang-commits at lists.llvm.org>, sunshaoce at iscas.ac.cn <sunshaoce at iscas.ac.cn>, everythingfunctional at protonmail.com <everythingfunctional at protonmail.com>, safonsof at amd.com <safonsof at amd.com>, Roger.VilasecaDarne at amd.com <Roger.VilasecaDarne at amd.com>, fruitclover at gmail.com <fruitclover at gmail.com>, vigbalas at amd.com <vigbalas at amd.com>, Renaud Kauffmann <rkauffmann at nvidia.com>, bhuvanendra.kumarn at amd.com <bhuvanendra.kumarn at amd.com>, raghavendhra20061088 at gmail.com <raghavendhra20061088 at gmail.com>, Peter Steinfeld <psteinfeld at nvidia.com>, aperry at lanl.gov <aperry at lanl.gov>, Jean Perier <jperier at nvidia.com>, tim at tkeith.com <tim at tkeith.com>, Dan.Palermo at amd.com <Dan.Palermo at amd.com>, soutomar at amd.com <soutomar at amd.com>, dominik.adamski at amd.com <dominik.adamski at amd.com>, isuruf at gmail.com <isuruf at gmail.com>, david.truby at arm.com <david.truby at arm.com>, ron.lieberman at amd.com <ron.lieberman at amd.com>, Slava Zakharin <szakharin at nvidia.com>, leandro.lupori at linaro.org <leandro.lupori at linaro.org>, kiranchandramohan at gmail.com <kiranchandramohan at gmail.com>, moll at cs.uni-saarland.de <moll at cs.uni-saarland.de>, Eric Schweitz <eschweitz at nvidia.com>, v.churavy at gmail.com <v.churavy at gmail.com>, michael.hliao at gmail.com <michael.hliao at gmail.com>, tarunprabhu at gmail.com <tarunprabhu at gmail.com>, shivam.gupta2 at amd.com <shivam.gupta2 at amd.com>
Subject: [PATCH] D155962 <https://reviews.llvm.org/D155962>: [flang] Compare component types In AreSameComponent()
External email: Use caution opening links or attachments

probinson added a comment.

@klausler this commit added a file `generic05.f90` when there was already a file in the same directory named `generic05.F90`. Note the difference `f` versus `F`. This causes checkouts on Windows to be unusable, because it has a case-insensitive filesystem.

Please revert this and change the name of the test file before recommitting. Thanks!

Repository:

  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION

  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD155962%2Fnew%2F&data=05%7C01%7Cpklausler%40nvidia.com%7Cb5630cfede9c4f06894708db8a2f6b45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638255708623198307%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Hn%2FNratbSrBNFOWA%2B0xGsY7vr5Kt38QmE%2BsnoLWDt4g%3D&reserved=0<https://reviews.llvm.org/D155962/new/>

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD155962&data=05%7C01%7Cpklausler%40nvidia.com%7Cb5630cfede9c4f06894708db8a2f6b45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638255708623198307%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=d5pRcKQ7jJXFWPrlQkXKpy0uAnnHSU1QtluiXvWLjnc%3D&reserved=0https://reviews.llvm.org/D155962

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155962/new/

https://reviews.llvm.org/D155962