[flang-commits] [PATCH] D155975: [flang] Fix portability warning that was incorrectly an "else if"

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: clementval.
klausler added a project: Flang.
Herald added subscribers: sunshaoce, jdoerfert.
Herald added a project: All.
klausler requested review of this revision.

A semantics check for an assumed-length dummy procedure pointer was
inappropriately part of an "else" clause for a preceding check,
causing it to not be applied in all situations.


https://reviews.llvm.org/D155975

Files:
  flang/lib/Semantics/check-declarations.cpp
  flang/test/Semantics/call01.f90


Index: flang/test/Semantics/call01.f90
===================================================================
--- flang/test/Semantics/call01.f90
+++ flang/test/Semantics/call01.f90
@@ -118,16 +118,19 @@
   end function nested
 end function
 
-subroutine s01(f1, f2, fp1, fp2)
+subroutine s01(f1, f2, fp1, fp2, fp3)
   !PORTABILITY: A dummy procedure pointer should not have assumed-length CHARACTER(*) result type
   character*(*) :: f1, f3, fp1
   external :: f1, f3
-  pointer :: fp1
+  pointer :: fp1, fp3
   !PORTABILITY: A dummy procedure pointer should not have assumed-length CHARACTER(*) result type
   procedure(character*(*)), pointer :: fp2
   interface
     character*(*) function f2()
     end function
+    !PORTABILITY: A dummy procedure pointer should not have assumed-length CHARACTER(*) result type
+    character*(*) function fp3()
+    end function
     !ERROR: A function interface may not declare an assumed-length CHARACTER(*) result
     character*(*) function f4()
     end function
Index: flang/lib/Semantics/check-declarations.cpp
===================================================================
--- flang/lib/Semantics/check-declarations.cpp
+++ flang/lib/Semantics/check-declarations.cpp
@@ -391,7 +391,8 @@
         messages_.Say(
             "An assumed-length CHARACTER(*) function cannot return a POINTER"_err_en_US);
       }
-    } else if (IsProcedurePointer(symbol) && IsDummy(symbol)) {
+    }
+    if (IsProcedurePointer(symbol) && IsDummy(symbol)) {
       messages_.Say(
           "A dummy procedure pointer should not have assumed-length CHARACTER(*) result type"_port_en_US);
       // The non-dummy case is a hard error that's caught elsewhere.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155975.542951.patch
Type: text/x-patch
Size: 1692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230721/0256fc22/attachment-0001.bin>