[flang-commits] [flang] e4d6860 - [flang] Fix -Wstring-conversion in PPCIntrinsicCall.cpp (NFC)

[Jie Fu via flang-commits]

Author: Jie Fu
Date: 2023-07-03T14:14:48+08:00
New Revision: e4d6860d2de450f5e34f129d05cb0a67703cab73

URL: https://github.com/llvm/llvm-project/commit/e4d6860d2de450f5e34f129d05cb0a67703cab73
DIFF: https://github.com/llvm/llvm-project/commit/e4d6860d2de450f5e34f129d05cb0a67703cab73.diff

LOG: [flang] Fix -Wstring-conversion in PPCIntrinsicCall.cpp (NFC)

/Users/jiefu/llvm-project/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp:617:14: error: implicit conversion turns string literal into bool: 'const char[39]' to 'bool' [-Werror,-Wstring-conversion]
      assert("Invalid vector operation for generator");
      ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Added: 
    

Modified: 
    flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp b/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
index a653bcaa8f0149..27050e1274ea64 100644
--- a/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
+++ b/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
@@ -614,7 +614,7 @@ PPCIntrinsicLibrary::genVecCmp(mlir::Type resultType,
       break;
     }
     default:
-      assert("Invalid vector operation for generator");
+      assert(false && "Invalid vector operation for generator");
     }
   } else if (vecTyInfo.isFloat()) {
     mlir::Value vargs[2];
@@ -631,12 +631,12 @@ PPCIntrinsicLibrary::genVecCmp(mlir::Type resultType,
       vargs[1] = argBases[0];
       break;
     default:
-      assert("Invalid vector operation for generator");
+      assert(false && "Invalid vector operation for generator");
     }
     auto callOp{builder.create<fir::CallOp>(loc, funcOp, vargs)};
     res = callOp.getResult(0);
   } else
-    assert("invalid vector type");
+    assert(false && "invalid vector type");
 
   return res;
 }