[flang-commits] [PATCH] D144916: [flang] Block construct

Pete Steinfeld via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Feb 27 15:14:15 PST 2023


PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Aside from a couple of clang-format diffs, all builds and tests correctly and looks good.



================
Comment at: flang/lib/Lower/Bridge.cpp:772
   Fortran::lower::StatementContext &getFctCtx() override final {
+    if (!activeConstructStack.empty() &&
+        activeConstructStack.back()
----------------
I'm seeing a `clang-format` diff here.


================
Comment at: flang/lib/Lower/Mangler.cpp:96-99
+      return fir::NameUniquer::doConstant(modules, procs, blockId,
+                                          symbolName);
+    return fir::NameUniquer::doVariable(modules, procs, blockId,
+                                        symbolName);
----------------
I'm seeing more clang-format diffs here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144916/new/

https://reviews.llvm.org/D144916



More information about the flang-commits mailing list