[flang-commits] [PATCH] D144513: [flang][hlfir] Array constructor lowering [part 3/4]

Jean Perier via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Feb 22 00:57:43 PST 2023


jeanPerier updated this revision to Diff 499402.
jeanPerier added a comment.

Correct typos in comments, clarify some comments, and make
some members and argument std::optional instead of relying
on the null mlir::Value state.
Thanks for the review Pete.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144513/new/

https://reviews.llvm.org/D144513

Files:
  flang/include/flang/Optimizer/Builder/FIRBuilder.h
  flang/include/flang/Optimizer/Builder/Runtime/ArrayConstructor.h
  flang/lib/Lower/ConvertArrayConstructor.cpp
  flang/lib/Optimizer/Builder/CMakeLists.txt
  flang/lib/Optimizer/Builder/FIRBuilder.cpp
  flang/lib/Optimizer/Builder/Runtime/ArrayConstructor.cpp
  flang/test/Lower/HLFIR/array-ctor-as-runtime-temp.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144513.499402.patch
Type: text/x-patch
Size: 29286 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230222/13aae42c/attachment-0001.bin>


More information about the flang-commits mailing list