[flang-commits] [PATCH] D143933: [flang] Fix USE rename

Leandro Lupori via Phabricator via flang-commits flang-commits at lists.llvm.org
Tue Feb 14 05:05:55 PST 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG1fae1464d7a7: [flang] Fix USE rename (authored by luporl).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143933/new/

https://reviews.llvm.org/D143933

Files:
  flang/lib/Semantics/resolve-names.cpp
  flang/test/Semantics/resolve116.f90


Index: flang/test/Semantics/resolve116.f90
===================================================================
--- /dev/null
+++ flang/test/Semantics/resolve116.f90
@@ -0,0 +1,24 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+! Test rename to the same name.
+module m1
+  integer, allocatable :: a(:)
+
+  interface operator(.add.)
+    module procedure add
+  end interface
+
+contains
+  integer function add(a, b)
+    integer, intent(in) :: a, b
+
+    add = a + b
+  end function
+end
+
+program p1
+  use m1, a => a, operator(.add.) => operator(.add.)
+
+  allocate(a(10))
+  deallocate(a)
+  print *, 2 .add. 2
+end
Index: flang/lib/Semantics/resolve-names.cpp
===================================================================
--- flang/lib/Semantics/resolve-names.cpp
+++ flang/lib/Semantics/resolve-names.cpp
@@ -2718,7 +2718,7 @@
   const auto &useName{std::get<1>(x.t)};
   AddUseRename(useName.source);
   SymbolRename rename{AddUse(localName.source, useName.source)};
-  if (rename.use) {
+  if (rename.use && localName.source != useName.source) {
     EraseRenamedSymbol(*rename.use);
   }
   Resolve(useName, rename.use);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143933.497279.patch
Type: text/x-patch
Size: 1144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230214/cf5d0171/attachment-0001.bin>


More information about the flang-commits mailing list