[flang-commits] [PATCH] D143824: [flang] Fix new assertion failure

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Sat Feb 11 12:20:25 PST 2023


klausler created this revision.
klausler added a reviewer: clementval.
klausler added a project: Flang.
Herald added subscribers: sunshaoce, jdoerfert.
Herald added a project: All.
klausler requested review of this revision.

Don't compute the address of  element [0] of a vector when the vector
is empty, even if the address is not used.


https://reviews.llvm.org/D143824

Files:
  flang/lib/Parser/token-sequence.cpp


Index: flang/lib/Parser/token-sequence.cpp
===================================================================
--- flang/lib/Parser/token-sequence.cpp
+++ flang/lib/Parser/token-sequence.cpp
@@ -264,8 +264,10 @@
 }
 
 void TokenSequence::Emit(CookedSource &cooked) const {
-  cooked.Put(&char_[0], char_.size());
-  cooked.PutProvenanceMappings(provenances_);
+  if (auto n{char_.size()}) {
+    cooked.Put(&char_[0], n);
+    cooked.PutProvenanceMappings(provenances_);
+  }
 }
 
 llvm::raw_ostream &TokenSequence::Dump(llvm::raw_ostream &o) const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143824.496707.patch
Type: text/x-patch
Size: 551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20230211/dc5f281e/attachment-0001.bin>


More information about the flang-commits mailing list