[flang-commits] [PATCH] D146485: Add tests from gfortran test suite [build files]

Kiran Chandramohan via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Apr 20 09:17:48 PDT 2023


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

In D146485#4277816 <https://reviews.llvm.org/D146485#4277816>, @tarunprabhu wrote:

> Add an option for the user to provide a path to the directory containing ISO_Fortran_bindings.h that is needed to run the tests.
>
> Added a README summarizing the current state of the gfortran tests.
>
> @kiranchandramohan, could you take a look at the README please. Thanks for all the reviews so far :-)
>
> I will be leaving this up for a few more days to give others a chance to test/review it.

Readme looks good. Patch still LGTM.



================
Comment at: Fortran/gfortran/regression/gomp/CMakeLists.txt:9
+
+# There are currently no tests in this directory to be disabled for any reason.
+add_tests("" "" "" "")
----------------
Is this because all the OpenMP tests are a compilation tests.

I guess we can provide an option (in later patches) to build all non-execute tests as well. Currently, no OpenMP tests are run.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146485/new/

https://reviews.llvm.org/D146485



More information about the flang-commits mailing list