[flang-commits] [PATCH] D148365: [flang] Remove `ignoring all compiler directives` warning

vdonaldson via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Apr 14 13:24:41 PDT 2023


vdonaldson added a comment.

In D148365#4269456 <https://reviews.llvm.org/D148365#4269456>, @PeteSteinfeld wrote:

> I wonder if we should put out a TODO message when directives get passed to lowering.  Otherwise, all builds and tests correctly and looks good.

No, that would have the identical problem that the warning message has, but would be worse because it would be fatal. It would be inaccurate for cases that are actually implemented and cases that don't have downstream component/s. A front end warning would serve the same purpose without these problems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148365/new/

https://reviews.llvm.org/D148365



More information about the flang-commits mailing list