[flang-commits] [flang] 4f1fa55 - [flang][NFC] Small refactor for `IsProcedurePointer`

Daniil Dudkin via flang-commits flang-commits at lists.llvm.org
Mon Jun 20 01:10:50 PDT 2022


Author: Daniil Dudkin
Date: 2022-06-20T11:10:30+03:00
New Revision: 4f1fa558c816095e4f01179a3bc674a4622f2efe

URL: https://github.com/llvm/llvm-project/commit/4f1fa558c816095e4f01179a3bc674a4622f2efe
DIFF: https://github.com/llvm/llvm-project/commit/4f1fa558c816095e4f01179a3bc674a4622f2efe.diff

LOG: [flang][NFC] Small refactor for `IsProcedurePointer`

Instead of manually checking for procedure-like details in Symbol,
defer it to IsProcedure function.

Differential Revision: https://reviews.llvm.org/D127967

Added: 
    

Modified: 
    flang/lib/Evaluate/tools.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Evaluate/tools.cpp b/flang/lib/Evaluate/tools.cpp
index 68faac50cb4eb..831c47022e788 100644
--- a/flang/lib/Evaluate/tools.cpp
+++ b/flang/lib/Evaluate/tools.cpp
@@ -1296,8 +1296,7 @@ const Symbol *FindCommonBlockContaining(const Symbol &original) {
 
 bool IsProcedurePointer(const Symbol &original) {
   const Symbol &symbol{GetAssociationRoot(original)};
-  return IsPointer(symbol) &&
-      (symbol.has<ProcEntityDetails>() || symbol.has<SubprogramDetails>());
+  return IsPointer(symbol) && IsProcedure(symbol);
 }
 
 // 3.11 automatic data object


        


More information about the flang-commits mailing list