[flang-commits] [PATCH] D127316: [flang][runtime] Remove dependency on C++ <mutex> on Windows

Diana Picus via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Jun 10 00:49:32 PDT 2022


rovka added a comment.

Hi @mmuetzel,

Thanks for submitting this! I think the NOMINMAX trick should fix the issues I was seeing on Windows on Arm, but I still need to test to be sure (it's slow...). Do you have commit access or should I commit on your behalf?
One small Phabricator nitpick: it's nice to upload patches with context <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface:~:text=one%20of%20the%20following%20commands> (you don't have to do that for this patch, I was just mentioning it for the future).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127316/new/

https://reviews.llvm.org/D127316



More information about the flang-commits mailing list