[flang-commits] [PATCH] D127316: [flang][runtime] Remove dependency on C++ <mutex> on Windows

Markus Mützel via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Jun 8 13:30:01 PDT 2022


mmuetzel added a comment.

In D127316#3567905 <https://reviews.llvm.org/D127316#3567905>, @klausler wrote:

> This patch oversimplifies the code, making it work only for WIN32 and with pthreads, but no longer with C++ mutexes.

The previous logic undefined `USE_PTHREADS` only on Windows and defined it to `1` everywhere else.
This change proposes an alternative implementation on Windows. It would be possible to leave in the code that uses `std::mutex`. But that part of the code would be essentially dead, and there would be no condition under which it would be compiled.

I can do that change. Just would like to confirm that this is really what you'd like to have.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127316/new/

https://reviews.llvm.org/D127316



More information about the flang-commits mailing list