[flang-commits] [flang] 85a40ce - [flang] Better error message for NULL() actual argument for dummy allocatable

[Peter Klausler via flang-commits]

Author: Peter Klausler
Date: 2022-07-25T10:09:55-07:00
New Revision: 85a40ce6ddf6abf06886dc594aeb998e05f75faa

URL: https://github.com/llvm/llvm-project/commit/85a40ce6ddf6abf06886dc594aeb998e05f75faa
DIFF: https://github.com/llvm/llvm-project/commit/85a40ce6ddf6abf06886dc594aeb998e05f75faa.diff

LOG: [flang] Better error message for NULL() actual argument for dummy allocatable

f18 intentionally does not support the spottily-implemented language extension
in which one can pass NULL() for an allocatable dummy argument.  This is perhaps
a sanctioned side effect in other compilers of the fact that they pass distinct
"base address" and "descriptor address" physical arguments.

Make the error message in this case more specific to the circumstances, and
add a note to Extensions.md to clarify that this behavior is intended.

(We could, with some effort in lowering, support passing NULL for an INTENT(IN)
allocatable dummy, but let's see whether such nonconforming usage appears
in a real application before spending any more time on it.)

Differential Revision: https://reviews.llvm.org/D130380

Added: 
    flang/test/Semantics/call27.f90

Modified: 
    flang/docs/Extensions.md
    flang/lib/Semantics/check-call.cpp

Removed: 
    


################################################################################
diff  --git a/flang/docs/Extensions.md b/flang/docs/Extensions.md
index e0c0bf6bfed79..71a3727ef00c3 100644
--- a/flang/docs/Extensions.md
+++ b/flang/docs/Extensions.md
@@ -308,6 +308,7 @@ end
   PGI converts the arguments while Intel and XLF replace the specific by the related generic.
 * VMS listing control directives (`%LIST`, `%NOLIST`, `%EJECT`)
 * Continuation lines on `INCLUDE` lines
+* `NULL()` actual argument corresponding to an `ALLOCATABLE` dummy data object
 
 ## Preprocessing behavior
 

diff  --git a/flang/lib/Semantics/check-call.cpp b/flang/lib/Semantics/check-call.cpp
index cbf48aef042c8..1667ac3dd792a 100644
--- a/flang/lib/Semantics/check-call.cpp
+++ b/flang/lib/Semantics/check-call.cpp
@@ -740,6 +740,15 @@ static void CheckExplicitInterfaceArg(evaluate::ActualArgument &arg,
                                        DummyDataObject::Attr::Optional)) &&
                     evaluate::IsNullPointer(*expr)) {
                   // ok, FOO(NULL())
+                } else if (object.attrs.test(characteristics::DummyDataObject::
+                                   Attr::Allocatable) &&
+                    evaluate::IsNullPointer(*expr)) {
+                  // Unsupported extension that more or less naturally falls
+                  // out of other Fortran implementations that pass separate
+                  // base address and descriptor address physical arguments
+                  messages.Say(
+                      "Null actual argument '%s' may not be associated with allocatable %s"_err_en_US,
+                      expr->AsFortran(), dummyName);
                 } else {
                   messages.Say(
                       "Actual argument '%s' associated with %s is not a variable or typed expression"_err_en_US,

diff  --git a/flang/test/Semantics/call27.f90 b/flang/test/Semantics/call27.f90
new file mode 100644
index 0000000000000..97c6304fb3e40
--- /dev/null
+++ b/flang/test/Semantics/call27.f90
@@ -0,0 +1,19 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+! Catch NULL() actual argement association with allocatable dummy argument
+program test
+  !ERROR: Null actual argument 'NULL()' may not be associated with allocatable dummy argument 'a='
+  call foo1(null())
+  !ERROR: Null actual argument 'NULL()' may not be associated with allocatable dummy argument 'a='
+  call foo2(null()) ! perhaps permissible later on user request
+  call foo3(null()) ! ok
+ contains
+  subroutine foo1(a)
+    real, allocatable :: a
+  end subroutine
+  subroutine foo2(a)
+    real, allocatable, intent(in) :: a
+  end subroutine
+  subroutine foo3(a)
+    real, allocatable, optional :: a
+  end subroutine
+end