[flang-commits] [PATCH] D129494: [flang] move getKindMapping() calls out of FIROpBuilder ctor calls

Jean Perier via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Jul 11 13:27:33 PDT 2022


jeanPerier added a comment.

In D129494#3642772 <https://reviews.llvm.org/D129494#3642772>, @PeteSteinfeld wrote:

> These changes look good.  But it looks like there are another two instances of this problem in .../flang/lib/Optimizer/CodeGen/TargetRewrite.cpp.  Did you take a look at that file?

Good Catch, thanks Pete ! I also updated them (the last call in `fir::CodeGenSpecifics::get` is what it should be, the KinMapping is moved there, not taken by reference).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129494/new/

https://reviews.llvm.org/D129494



More information about the flang-commits mailing list