[flang-commits] [PATCH] D129481: [flang] Merge GEPs in substring fir.embox codegen
Valentin Clement via Phabricator via flang-commits
flang-commits at lists.llvm.org
Mon Jul 11 05:43:29 PDT 2022
clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.
LGTM. Maybe one typo.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1403
+ // The indices from the "outer" dimension (every dimension after the first
+ // on that is not a compile time constant included) must have been
+ // multiplied with the related extent and added together into \p outerOffset.
----------------
typo?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129481/new/
https://reviews.llvm.org/D129481
More information about the flang-commits
mailing list