[flang-commits] [PATCH] D129316: Shift intrinsics

[Tarun Prabhu via Phabricator via flang-commits]

tarunprabhu added a comment.

> Is it necessary to return 0 for nonconformant calls, or would it be more efficient to omit the SelectOp's and just do a simple shift, where "whatever happens, happens" for nonconformant calls?

I may have misunderstood @klausler  here (https://discourse.llvm.org/t/dealing-with-invalid-arguments-in-intrinsics/63630/4?u=tarunprabhu).

I took his reply to mean that some degree of uniformity with other compilers is desirable although that might seem to incur a performance penalty in this case. I have limited experience with Fortran, and thus not best placed to comment on the preferred course of action. I am happy to modify this patch as others see fit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129316/new/

https://reviews.llvm.org/D129316