[flang-commits] [PATCH] D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct.

sameeran joshi via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Dec 18 10:57:07 PST 2020


sameeranjoshi marked 3 inline comments as done.
sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:1065
+  const parser::Name *mayBeName{&name};
+  if (mayBeName) {
+    if (auto *resolvedSymbol{
----------------
tskeith wrote:
> What is the purpose of introducing `maybeName` when you can just use `name`?
Thanks.
Not sure what I was trying to do here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93051/new/

https://reviews.llvm.org/D93051



More information about the flang-commits mailing list