
<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">No worries.<div class=""><br class=""></div><div class="">In the meantime I am going to rebase my patches on top of rCTE336549 [clangd] Remove JSON library in favor of llvm/Support/JSON.<div class=""><br class=""></div><div class="">Enjoy your vacation!</div><div class=""><br class=""></div><div class="">Cheers,</div><div class=""><br class=""></div><div class="">Jan<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 11, 2018, at 4:56 PM, Ilya Biryukov <<a href="mailto:ibiryukov@google.com" class="">ibiryukov@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Sorry for not getting to the review, got distracted by other things.<div class=""><br class=""></div><div class="">I'll be on vacation till Jul 23, so I won't be available before that date. However, AFAIK Sam is still planning to take a look at the changes and I'm happy to help with it after getting back.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Jun 28, 2018 at 9:27 PM Sam McCall via clangd-dev <<a href="mailto:clangd-dev@lists.llvm.org" class="">clangd-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="">Also happy to take a look here.<div dir="auto" class="">I think the split you described is right - the details of XPC are more interesting to Apple, the interfaces are of wider interest.</div><div dir="auto" class="">I'd still like to look at least a bit at each patch, to understand how we should be adapting if the JSON output and/or protocol structs change in future and so on.</div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">Will try to get into this tomorrow, thanks for the heads-up!</div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">Cheers, Sam</div><br class=""><br class=""><div class="gmail_quote" dir="auto"><div dir="ltr" class="">On Thu, Jun 28, 2018, 20:07 Jan Korous via clangd-dev <<a href="mailto:clangd-dev@lists.llvm.org" target="_blank" class="">clangd-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class="">Hi all,<div class=""><br class=""></div><div class="">I would like to ask if there are volunteers to help us with code review - we finally have patches with alternative transport layer we promised at EuroLLVM ready.</div><div class=""><br class=""></div><div class="">While I assume (but please correct me if I am wrong) that it would be fine to have our specific XPC stuff reviewed by other Apple folks I feel it would be more appropriate to have changes impacting the common code reviewed by clangd community.</div><div class=""><br class=""></div><div class="">If anyone is willing to take a look - patches are here: </div><div class=""><br class=""></div><div class=""><div class="">[clangd] refactoring for XPC transport layer [NFCI]</div><div class=""><a href="https://reviews.llvm.org/D48559" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D48559</a></div></div><div class="">This is probably the most interesting patch for the community as it changes current clangd design in order to be able to accommodate alternative dispatcher.</div><div class=""><br class=""></div><div class=""><div class=""><div class="">[clangd] JSON <-> XPC conversions</div></div></div><div class=""><a href="https://reviews.llvm.org/D48560" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D48560</a></div><div class="">Small, self-contained patch - conversion functions and tests.</div><div class=""><br class=""></div><div class=""><div class="">[clangd] XPC transport layer</div></div><div class=""><a href="https://reviews.llvm.org/D48562" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D48562</a></div><div class="">Implementation of alternative transport layer. We are currently having this patch reviewed internally but if there’s interest in community it would be awesome to have it reviewed on phab as well.</div><div class=""><br class=""></div><div class="">Thank you.</div><div class=""><br class=""></div><div class="">Jan</div></div>_______________________________________________<br class="">

clangd-dev mailing list<br class="">

<a href="mailto:clangd-dev@lists.llvm.org" rel="noreferrer" target="_blank" class="">clangd-dev@lists.llvm.org</a><br class="">

<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/clangd-dev" rel="noreferrer noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/clangd-dev</a><br class="">

</blockquote></div></div>

_______________________________________________<br class="">

clangd-dev mailing list<br class="">

<a href="mailto:clangd-dev@lists.llvm.org" target="_blank" class="">clangd-dev@lists.llvm.org</a><br class="">

<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/clangd-dev" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/clangd-dev</a><br class="">

</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">Regards,</div><div class="">Ilya Biryukov</div></div></div></div></div>

</div></blockquote></div><br class=""></div></div></body></html>