<div dir="ltr"><div dir="ltr">On Wed, 28 Apr 2021 at 13:53, Taylor, Max via cfe-users <<a href="mailto:cfe-users@lists.llvm.org">cfe-users@lists.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="gmail-m_1798052004550199881WordSection1">
<p class="MsoNormal">Greetings.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I’m building a source-to-source tool with clang. What I want to do is instrument stores made with the binary = operator. Currently, I’m running into problems with rewriting expressions that contain macro invocations. I’ve done some digging
around, and I found some info that helped with my understanding (e.g. <a href="https://stackoverflow.com/questions/24062989/clang-fails-replacing-a-statement-if-it-contains-a-macro" target="_blank">
https://stackoverflow.com/questions/24062989/clang-fails-replacing-a-statement-if-it-contains-a-macro</a>). But I’m still not sure how to solve this problem.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Concretely, suppose you have:<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">#define a(x) ((x) * 10 + 1)<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">class my_class {<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> int x;<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">public:<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> int my_function() {<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> x = a(0);<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> return x;<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> }<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">};<u></u><u></u></p>
<p class="MsoNormal"><span style="font-family:"American Typewriter",serif"><u></u> <u></u></span></p>
<p class="MsoNormal">I want to rewrite this into something like this:<span style="font-size:10pt;font-family:"Cousine for Powerline";color:rgb(242,242,242)">
<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:0.5in">#ifndef _instrument_noclash<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">#define _instrument_noclash(name, expr, instance_no) \<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> (*({ \<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> typeof(expr) *_t_instrument_no_clash##instance_no = &(expr); \<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> _t_instrument_no_clash##instance_no; \<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> }))<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">#endif<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">#define a(x) ((x) * 10 + 1)<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">class my_class {<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> int x;<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">public:<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> int my_function() {<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> _instrument_noclash("x",(this->x=((0) * 10 + 1)),0);<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> return x;<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"> }<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in">};<u></u><u></u></p>
<p class="MsoNormal"><span style="font-family:"American Typewriter",serif"><u></u> <u></u></span></p>
<p class="MsoNormal">The problem (to me) is simple: <b>how do I determine the physical location of the ending of the expression on the right hand sign of the = operator?
</b>Without this knowledge, I end up overwriting the end of the statement. Scanning the APIs, it seems like there isn’t a simple way to do this. I’ve tried several ways to get the ending source location:<u></u><u></u></p>
<ol style="margin-top:0in" start="1" type="1">
<li class="gmail-m_1798052004550199881MsoListParagraph" style="margin-left:0in">op->getEndLoc(), where op is an instance of BinaryOperator. This doesn’t work, because the ending location in the AST is not the same as the physical end location of the expression,
due to macro expansion.<u></u><u></u></li><li class="gmail-m_1798052004550199881MsoListParagraph" style="margin-left:0in">sm.getSpellingLoc(op->getEndLoc()), where sm is the source manager. This just returns op->getEndLoc().<u></u><u></u></li><li class="gmail-m_1798052004550199881MsoListParagraph" style="margin-left:0in">sm.getExpansionLoc(op->getEndLoc()). This is close, but the location returned is the end of the macro name, so the macro arguments are not removed.</li></ol></div></div></blockquote><div>sm.getExpansionRange(op->getEndLoc()).getEnd() should work in this case. In general what you're trying to do is not possible, because the assignment expression might end in the middle of the macro expansion, though; depending on exactly what your goal is, it might be easiest to first preprocess the source file and then run your transform.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US" style="overflow-wrap: break-word;"><div class="gmail-m_1798052004550199881WordSection1">
<p class="MsoNormal">Any suggestions (or easier way to achieve this same goal) are appreciated.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">-Max<u></u><u></u></p>
</div>
</div>
_______________________________________________<br>
cfe-users mailing list<br>
<a href="mailto:cfe-users@lists.llvm.org" target="_blank">cfe-users@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-users" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-users</a><br>
</blockquote></div></div>